Rollup of 5 pull requests #114697
Merged
Rollup of 5 pull requests #114697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <work@onurozkan.dev>
…m/array/tuple literals unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point
Just remove a typo.
…-config, r=clubby789 better error handling for `rust.codegen-backends` on deserialization Fixes rust-lang#109315
…ler-errors Add clubby789 to `users_on_vacation` I'm on holiday until the 30th of August so won't be able to take on reviews until then
…fects, r=compiler-errors `Expr::can_have_side_effects()` is incorrect for struct/enum/array/tuple literals It would return 'false' unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point The function is only used for simple lints and error messages, so not a serious bug.
doc (unstable-book): fix a typo Just fix a small typo.
…, r=lcnr Remove redundant calls to `resolve_vars_with_obligations` I've been auditing the calls to `resolve_vars_with_obligations` for the new solver, and have found a few that have no effect on diagnostics. Let's just remove 'em. Also remove a redundant `resolve_vars_with_obligations_and_mutate_fulfillment` call. r? ``@lcnr``
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 9fa6bdd764 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (faee636): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.25s -> 632.409s (0.03%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust.codegen-backendson deserialization #114278 (better error handling forrust.codegen-backendson deserialization)users_on_vacation#114674 (Add clubby789 tousers_on_vacation)Expr::can_have_side_effects()is incorrect for struct/enum/array/tuple literals #114678 (Expr::can_have_side_effects()is incorrect for struct/enum/array/tuple literals)resolve_vars_with_obligations#114684 (Remove redundant calls toresolve_vars_with_obligations)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup